fix: file/directory permissions within the zip while packaging artifacts#4655
Merged
sriram-mv merged 8 commits intoaws:developfrom Feb 15, 2023
Merged
Conversation
jfuss
approved these changes
Feb 3, 2023
Contributor
jfuss
left a comment
jfuss
left a comment
There was a problem hiding this comment.
Probably out of scope for this PR but I think it would be a good idea to add integration tests for a compiled and interpreted language that package, deploy, and then invoke the function. I will leave that up to you but at the very least, I think we should add that before this is released.
mndeveci
reviewed
Feb 3, 2023
Contributor
mndeveci
left a comment
mndeveci
left a comment
There was a problem hiding this comment.
Thanks for the change! I've requested some small changes to make it more readable. I also agree for adding an integration test to verify this behavior which would also help us to not break this in the future.
sriram-mv
force-pushed
the
reintroduce_package_permissions
branch
2 times, most recently
from
67827a3 to
c8e78d5
Compare
* Additive permissions to add execute on directories and read on files.
sriram-mv
force-pushed
the
reintroduce_package_permissions
branch
2 times, most recently
from
599f0ab to
2e56ea6
Compare
sriram-mv
force-pushed
the
reintroduce_package_permissions
branch
from
2e56ea6 to
c961fb7
Compare
mndeveci
approved these changes
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.